Skip to content
This repository was archived by the owner on Mar 13, 2025. It is now read-only.

Implemented functionality to wait & sync host's calendar before requesting interview. #594

Merged
merged 3 commits into from Dec 20, 2021

Conversation

ghost
Copy link

@ghost ghost commented Dec 17, 2021

This commit addresses issue #588.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahidulalvi-bonic generally works great!

A few small issues:

  1. Can we show text scheduling interview... under the loader indicator after we hide syncing your new calendar [email protected], it might take a few minutes...? As now it doesn't show any text, and it would be nice to let user know, that at this moment calendar is synced and we already scheduling an interview, https://monosnap.com/file/HbxpM0HJola8rHtAvfGGdTdyCvUzln

  2. Can we make "manage connected calendars" a link that would lead to the Manager Calendars screen? So you user can directly click it from this message, is it hard? https://monosnap.com/file/eMGSC9RnI4LPO1eYf6OxdYu6eCd8W5

  3. Let's, make [email protected] an active link to email. https://monosnap.com/file/eMGSC9RnI4LPO1eYf6OxdYu6eCd8W5

Specifically, the loading message is updated when sync is complete & added links for support & calendar management.
@ghost
Copy link
Author

ghost commented Dec 19, 2021

Hi @maxceem,

I've updated the PR. Totally missed 2 & 3.

Thanks.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mahidulalvi-bonic all works good for me. I'm merging this PR and passing it for QA.

@maxceem maxceem merged commit b757d12 into topcoder-archive:dev Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants